Fixing ci, adding python3.5 python3.6 #27
Conversation
| - python: 3.6 | ||
| env: TOX_ENV=py36 | ||
| - python: pypy | ||
| env: TOX_ENV=pypy |
There was a problem hiding this comment.
I don't understand, we shouldn't need to specify the python versions here because tox should take care of that. If it doesn't then what is the point of using tox at all?
There was a problem hiding this comment.
i think the reason is that travis does not come with python3.6 pre-istalled. Tox creates a virtualenv from this executable.
There was a problem hiding this comment.
exactly, but if you're specifying python: 3.6 then you're telling TravisCI to run in a container that uses Python 3.6 by default.
we're using tox so that we can run Python 2.7 locally (or whatever version you use) and tox will take care of creating a virtualenv with the correct Python version for the test that it currently is running.
There was a problem hiding this comment.
i thought virtualenv needed an executable of the correction python version?
There was a problem hiding this comment.
nope, tox should take care of putting the correct python version into the virtualenv
No description provided.