Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid test cases for slugify #212

Open
zfLQ2qx2 opened this issue Mar 2, 2020 · 1 comment · May be fixed by #487
Open

Invalid test cases for slugify #212

zfLQ2qx2 opened this issue Mar 2, 2020 · 1 comment · May be fixed by #487
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zfLQ2qx2
Copy link

zfLQ2qx2 commented Mar 2, 2020

I noticed a couple issues in the test cases for slugify -

してください
-- should transliterate as shitekudasai instead of sitekudasai

control:\x07notcontrol:\xB5
-- the code point \xB5 is invalid, should be \xC2\xB5 or \u00B5
@ErisDS
Copy link
Member

ErisDS commented Mar 20, 2020

The first one would need to be reported to unidecode.

The second one I'm happy to accept a PR :)

@daniellockyer daniellockyer added bug Something isn't working good first issue Good for newcomers labels Jun 15, 2023
keshav1sharma added a commit to keshav1sharma/SDK that referenced this issue Dec 30, 2023
@keshav1sharma
Resolved Invalid test cases for slugify
2778929 
closes TryGhost#212
-Replaced invalid escape sequence with the required unicode escape sequence.
@keshav1sharma keshav1sharma linked a pull request Dec 30, 2023 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolved Invalid test cases for slugify keshav1sharma/SDK
3 participants
@ErisDS @daniellockyer @zfLQ2qx2