馃悰 Fixed sending multiple support email verification emails #15044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs https://github.com/TryGhost/Team/issues/1686 - When the settings are updated with the `members_support_address` key present, it would always send a verification email - Root cause is that the service failed to check if the email was changed or not. Due to a bug it always thought the email was changed, triggering the verification flow. - The admin app will always send all the settings keys when changing some other value. This causes a lot of email verification emails. - Added tests and email count checks in tests
Codecov Report
@@ Coverage Diff @@
## main #15044 +/- ##
=======================================
Coverage 61.48% 61.48%
=======================================
Files 597 597
Lines 47944 47944
Branches 4325 4325
=======================================
Hits 29476 29476
Misses 18419 18419
Partials 49 49
Continue to review full report at Codecov.
|
matthanley
approved these changes
Jul 19, 2022
daniellockyer
pushed a commit
that referenced
this pull request
Jul 19, 2022
refs TryGhost/Product#1686 - When the settings are updated with the `members_support_address` key present, it would always send a verification email - Root cause is that the service failed to check if the email was changed or not. Due to a bug it always thought the email was changed, triggering the verification flow. - The admin app will always send all the settings keys when changing some other value. This causes a lot of email verification emails. - Added tests and email count checks in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/1686
members_support_addresskey present, it would always send a verification email