Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Member Counter template helpers #15013

Merged
merged 15 commits into from Jul 14, 2022

Conversation

ronaldlangeveld
Copy link
Member

@ronaldlangeveld ronaldlangeveld commented Jul 8, 2022

ref https://github.com/TryGhost/Team/issues/1667

Introducing 2 new helper handlebars tags, {{total_members}} and {{total_paid_members}} ideal for Member Sites who want to display these metrics to incentivise users to upgrade.

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #15013 (ab9046e) into main (d65aa08) will increase coverage by 0.03%.
The diff coverage is 78.31%.

@@            Coverage Diff             @@
##             main   #15013      +/-   ##
==========================================
+ Coverage   61.07%   61.10%   +0.03%     
==========================================
  Files         593      596       +3     
  Lines       47557    47640      +83     
  Branches     4271     4290      +19     
==========================================
+ Hits        29045    29110      +65     
- Misses      18463    18481      +18     
  Partials       49       49              
Impacted Files Coverage Δ
core/frontend/helpers/total_paid_members.js 62.50% <62.50%> (ø)
core/frontend/helpers/total_members.js 64.70% <64.70%> (ø)
core/frontend/utils/member-count.js 88.00% <88.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65aa08...ab9046e. Read the comment docs.

@ronaldlangeveld ronaldlangeveld marked this pull request as ready for review July 9, 2022 12:39
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@allouis allouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only thing is the comments at the top of the helpers files, which are weird - but they do follow existing patterns ☺️

Am not fussed if they stay or go

@ronaldlangeveld ronaldlangeveld merged commit a0c8db4 into TryGhost:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants