New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Member Counter template helpers #15013
✨ Member Counter template helpers #15013
Conversation
ref TryGhost/Product#1667 Introducing 2 new helper handlebars tags, `{{total_members}}` and `{{total_paid_members}}` ideal for Member Sites who want to display these metrics to incentivise users to upgrade.
This reverts commit 06ed36e.
Codecov Report
@@ Coverage Diff @@
## main #15013 +/- ##
==========================================
+ Coverage 61.07% 61.10% +0.03%
==========================================
Files 593 596 +3
Lines 47557 47640 +83
Branches 4271 4290 +19
==========================================
+ Hits 29045 29110 +65
- Misses 18463 18481 +18
Partials 49 49
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - only thing is the comments at the top of the helpers files, which are weird - but they do follow existing patterns
Am not fussed if they stay or go
ref https://github.com/TryGhost/Team/issues/1667
Introducing 2 new helper handlebars tags,
{{total_members}}
and{{total_paid_members}}
ideal for Member Sites who want to display these metrics to incentivise users to upgrade.