Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fixed member exports timing out for large sites (#14876) #14878

Merged

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented May 20, 2022

This is a cherry pick of 61aa30b but the tests fail on 5.0 and I can't see why 馃

refs TryGhost/Product#1641

This commit adds a custom query for the members export, to improve the performance and to prevent any timeouts from happening when exporting large amounts of members.
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #14878 (32acdd9) into main (d6d6841) will decrease coverage by 0.10%.
The diff coverage is 9.67%.

@@            Coverage Diff             @@
##             main   #14878      +/-   ##
==========================================
- Coverage   61.96%   61.86%   -0.11%     
==========================================
  Files         568      569       +1     
  Lines       45984    46067      +83     
  Branches     4190     4191       +1     
==========================================
+ Hits        28495    28499       +4     
- Misses      17445    17524      +79     
  Partials       44       44              
Impacted Files Coverage 螖
core/server/services/members/exporter/query.js 6.81% <6.81%> (酶)
...ver/api/canary/utils/serializers/output/members.js 86.70% <33.33%> (+0.72%) 猬嗭笍
core/server/services/members/service.js 48.06% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d6d6841...32acdd9. Read the comment docs.

@ErisDS ErisDS merged commit 8dd009f into TryGhost:main May 20, 2022
@ErisDS ErisDS deleted the cp-61aa30bba88c8de68098a0be3785169680ea3707 branch May 20, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants