[4.x] Fixed newsletter header image path #14690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs https://github.com/TryGhost/Team/issues/1579 - When writing to the database, the header_image is tranformed to the transformReady path - When reading from the database, the transformReady path is transformed to an absolute path - Includes a test when adding a newsletter
refs https://github.com/TryGhost/Team/issues/1579 - Updates all newsletter who have a header_image to make sure it is saved in transform ready format - Down operation is required to work with the old model logic and transforms it back to an absolute format
|
It looks like this PR contains a migration 👀 General requirements
Data changes
|
Codecov Report
@@ Coverage Diff @@
## 4.x #14690 +/- ##
==========================================
- Coverage 59.85% 59.83% -0.03%
==========================================
Files 580 580
Lines 47993 48016 +23
Branches 4217 4217
==========================================
+ Hits 28727 28730 +3
- Misses 19225 19245 +20
Partials 41 41
Continue to review full report at Codecov.
|
allouis
approved these changes
May 4, 2022
matthanley
approved these changes
May 4, 2022
matthanley
pushed a commit
to matthanley/Ghost
that referenced
this pull request
May 4, 2022
refs https://github.com/TryGhost/Team/issues/1579 - When writing to the database, the header_image is tranformed to the transformReady path - When reading from the database, the transformReady path is transformed to an absolute path - Includes a test when adding a newsletter Migration: - Updates all newsletter who have a header_image to make sure it is saved in transform ready format - Down operation is required to work with the old model logic and transforms it back to an absolute format
matthanley
pushed a commit
that referenced
this pull request
May 5, 2022
refs https://github.com/TryGhost/Team/issues/1579 - When writing to the database, the header_image is tranformed to the transformReady path - When reading from the database, the transformReady path is transformed to an absolute path - Includes a test when adding a newsletter Migration: - Updates all newsletter who have a header_image to make sure it is saved in transform ready format - Down operation is required to work with the old model logic and transforms it back to an absolute format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/1579
Migration:
5.x version: #14688