Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Move generated app to use Jest as test solution #447

Closed
ferrannp opened this issue Jan 23, 2017 · 5 comments
Closed

Move generated app to use Jest as test solution #447

ferrannp opened this issue Jan 23, 2017 · 5 comments
Assignees
Milestone

Comments

@ferrannp
Copy link
Contributor

ferrannp commented Jan 23, 2017

Following #406. We can remove all other dependencies and use also Jest in generated app (recommended by community and used it in React and Redux projecst). User can also choose to use Snapshots if they want too (maybe we could pass a flag to generate snapshot test if they want to).

This will also fix #333 since we won't need istanbul anymore.

This depends on following PR: #437 & #445

@grabbou
Copy link
Contributor

grabbou commented Jan 23, 2017

How that would provide a backwards-compatible environment for existing apps? I imagine it's not easy. Maybe a flag experimental to run jest tests only and make time for codebases to upgrade?

@grabbou
Copy link
Contributor

grabbou commented Jan 23, 2017

( @toddw I think it could ship as a plugin at some point, kinda gluestick-compat that has pre-jest tests etc. )

@toddw
Copy link
Contributor

toddw commented Jan 23, 2017

If more people were using GlueStick outside of TrueCar then gluestick-compat would probably be worth the effort. Since we are still pre 1.0 and TrueCar is the only known user in production I'm happy with 1.0 breaking backwards compatibility. We will update our apps as needed. To help with that: https://github.com/skovhus/jest-codemods

If anyone watching this project has objections, please let use know and I think it would help change our mind.

@toddw toddw added this to the 1.0 milestone Jan 23, 2017
@toddw
Copy link
Contributor

toddw commented Jan 24, 2017

We need to make sure we can debug tests in the generated apps. A comment on the node-inspector PR mentioned that it only works for individual tests. If that is true we need to at least support that but ideally it would be nice to be able to debug anywhere you want to.

#445 (comment)

@zamotany
Copy link
Contributor

zamotany commented Jan 24, 2017

Generated apps should be fine, I tested it and debugging all test at one works.
But when debugging with Jest --env jestEnvironmentNodeDebug.js (similarly as npm debug script in gluestick) still needs to be passed though.

Plus --debug-brk must be used, because debugger; statements are omitted if inspector is not connected.

@ferrannp ferrannp moved this from In Progress to Ready For Review in [CLOSED] Sprint 1 Jan 30, 2017
@ferrannp ferrannp moved this from Ready For Review to Done in [CLOSED] Sprint 1 Jan 30, 2017
olga32123 pushed a commit that referenced this issue Feb 2, 2017
olga32123 pushed a commit that referenced this issue Feb 2, 2017
olga32123 pushed a commit that referenced this issue Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants