Skip to content

Opt-out of base64 fallback #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott opened this issue Aug 29, 2022 · 2 comments
Closed

Opt-out of base64 fallback #341

Trott opened this issue Aug 29, 2022 · 2 comments

Comments

@Trott
Copy link
Owner

Trott commented Aug 29, 2022

Hey, first of all, really nice library, great job!

Wouldn't it be a better way to have base64 fallback as an option? Then it would be open for extension and if someone needed other encoding or no slug at all they could just add it on top of the library.

I would benefit from "no-slug" option in my project but I see that the underlying slugify function is encapsulated. If there was an easy way to access it then it would also be much nicer.

Originally posted by @antonipelka in #27 (comment)

@Trott
Copy link
Owner Author

Trott commented Aug 29, 2022

I wonder if the fallback is Too Much Magic™ and should be removed in a breaking change.

@antonipelka
Copy link
Contributor

Hey, created a PR above.

I wonder if the fallback is Too Much Magic™ and should be removed in a breaking change.

It's easier to add than to remove they say. Having it as an option will be a huge relief already!

@Trott Trott closed this as completed in b703043 Aug 31, 2022
github-actions bot pushed a commit that referenced this issue Aug 31, 2022
# [6.1.0](v6.0.0...v6.1.0) (2022-08-31)

### Features

* add fallback option ([#342](#342)) ([b703043](b703043)), closes [#341](#341)
josephkam1 added a commit to josephkam1/slug that referenced this issue Apr 23, 2024
# [6.1.0](Trott/slug@v6.0.0...v6.1.0) (2022-08-31)

### Features

* add fallback option ([#342](Trott/slug#342)) ([b703043](Trott/slug@b703043)), closes [#341](Trott/slug#341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants