Skip to content

doesn't support arabic #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
musabkhunaijir opened this issue Feb 26, 2019 · 4 comments
Closed

doesn't support arabic #1

musabkhunaijir opened this issue Feb 26, 2019 · 4 comments

Comments

@musabkhunaijir
Copy link

No description provided.

@Trott
Copy link
Owner

Trott commented Mar 29, 2019

Can you provide some sample code showing the problem? Is it that provided Arabic characters results in an error or bad results or something else?

@musabkhunaijir
Copy link
Author

musabkhunaijir commented Mar 30, 2019

var slug = require("slug")

console.log(slug("hi there"));
//"hi-there"

console.log(slug("مرحبا بك"));
// ""

@Trott
Copy link
Owner

Trott commented Mar 30, 2019

Thanks for reporting the issue. I just published version 1.1.0 which adds support for Arabic.

var slug = require("slug")

console.log(slug("hi there"));
//"hi-there"

console.log(slug("مرحبا بك"));
// "mrhb-bk"

@Trott Trott closed this as completed Mar 30, 2019
@musabkhunaijir
Copy link
Author

thanks

github-actions bot pushed a commit that referenced this issue Oct 13, 2020
## [3.5.1](v3.5.0...v3.5.1) (2020-10-13)

### Bug Fixes

* add ة،ء missing Arabic characters ([#1](#1)) ([0366d3a](0366d3a))
josephkam1 added a commit to josephkam1/slug that referenced this issue Apr 23, 2024
## [3.5.1](Trott/slug@v3.5.0...v3.5.1) (2020-10-13)

### Bug Fixes

* add ة،ء missing Arabic characters ([#1](Trott/slug#1)) ([0366d3a](Trott/slug@0366d3a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants