util.sh has invalid test

[jessebutryn]

Line 234 in util.sh is testing the exit code of the previous command but suffers from SC2155

Since local is being used for the variable assignment that line will always exit with 0.

Testing:

test-func () { local var=$(this-is-not-a-real-command); echo $? ;}

$ test-func
-bash: this-is-not-a-real-command: command not found
0

Due to this I believe it should be modified to:

    local manta_url
    manta_url=$(json -f "${METADATA}" MANTA_URL)
    [[ $? -eq 0 ]] || fatal "Unable to retrieve MANTA_URL from metadata"

Note: This issue is also found on line 217

[jessebutryn]

Additionally you can test on the command/assignment itself:

local manta_url
if ! manta_url=$(json -f "${METADATA}" MANTA_URL); then
  fatal "Unable to retrieve MANTA_URL from metadata"
fi