Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from promptui to survey #17

Closed
TrickyTroll opened this issue Aug 2, 2021 · 0 comments · Fixed by #18
Closed

Move from promptui to survey #17

TrickyTroll opened this issue Aug 2, 2021 · 0 comments · Fixed by #18
Assignees
Labels
enhancement New feature or request

Comments

@TrickyTroll
Copy link
Owner

Summary

Using survey, I noticed that it works a lot better than promptui for what I want to do with it. One of the main problems with promptui is that when a long path is provided (longer than the terminal's width), a new line is created on each keystroke. This also happens when copy pasting a long path. An issue has been filled but there has not been an answer from the author yet.

What to do

survey works in a similar way to promptui with validation. A validation function has to return an error when the input isn't valid. The main difference is that survey only validates the input after the user presses the enter key, while promptui checks it on each keystroke.

This means that the validation functions can be kept and the only thing that needs to be changed is the prompt implementation.

Useful links

@TrickyTroll TrickyTroll added the enhancement New feature or request label Aug 2, 2021
@TrickyTroll TrickyTroll self-assigned this Aug 2, 2021
@TrickyTroll TrickyTroll added this to To do in CLI planning via automation Aug 2, 2021
@TrickyTroll TrickyTroll moved this from To do to In progress in CLI planning Aug 2, 2021
CLI planning automation moved this from In progress to Done Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant