Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie Breaker #7807

Closed
drew2a opened this issue Jan 8, 2024 · 2 comments · Fixed by #7829
Closed

Tie Breaker #7807

drew2a opened this issue Jan 8, 2024 · 2 comments · Fixed by #7829
Assignees

Comments

@drew2a
Copy link
Collaborator

drew2a commented Jan 8, 2024

We have had, have, and will have PRs with conflicts between an author and a reviewer. Although it is preferable to find a consensus by the parties alone (by following the Google Gude Book for example), it is not always possible.

An example: #7764 (comment)

To resolve conflicts like this we collectively agreed (@synctext, @xoriole, @egbertbouman, @kozlovsky, @drew2a) to introduce a Tie Breaker mechanism which will follow: in the case of disagreement between the PR author and a reviewer, the PR author or reviewer could ask for a second opinion from a randomly chosen developer (tie breaker); the decision from the tie breaker is the final decision in the dispute, and both parties should adhere to it.

To implement the mechanism, I propose creating a GitHub Action that reacts to a specific comment (like 'second opinion', 'tie breaker', or suggest yours) and adds a randomly chosen developer from the Tribler Reviewers Team as a reviewer for the PR. The Tie Breaker should provide their resolution for the conflict situation.

Another way to trigger the action is to add a specific label to the PR (like 'conflict', 'need a resolution', 'tie breaker').

Please comment on the idea itself and the way it should be implemented (GitHub actions or not? Comment or label? etc.).

@drew2a drew2a self-assigned this Jan 8, 2024
@kozlovsky
Copy link
Collaborator

adds a randomly chosen developer from the Tribler Reviewers Team as a reviewer for the PR

Ideally, a randomly chosen developer should not be the PR author or the original reviewer :)

@xoriole
Copy link
Contributor

xoriole commented Jan 8, 2024

I like the idea of the label instead of the comment.
Suggestion for the label: second reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants