Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: test_http_get_with_redirect #7767

Closed
drew2a opened this issue Dec 11, 2023 · 1 comment · Fixed by #7771
Closed

Flaky test: test_http_get_with_redirect #7767

drew2a opened this issue Dec 11, 2023 · 1 comment · Fixed by #7771

Comments

@drew2a
Copy link
Collaborator

drew2a commented Dec 11, 2023

https://github.com/Tribler/tribler/actions/runs/7143968388/job/19456591712?pr=7764#step:8:2723 in #7764

_________________________ test_http_get_with_redirect __________________________

magnet_redirect_server = 33747

    async def test_http_get_with_redirect(magnet_redirect_server):
        """
        Test if http_get is working properly if url redirects to a magnet link.
        """
        # Setup a redirect server which redirects to a magnet link
        magnet_link = "magnet:?xt=urn:btih:DC4B96CF85A85CEEDB8ADC4B96CF85A85CEEDB8A"
    
        test_url = "http://localhost:%d" % magnet_redirect_server
        async with ClientSession() as session:
>           response = await session.get(test_url, allow_redirects=False)

magnet_link = 'magnet:?xt=urn:btih:DC4B96CF85A85CEEDB8ADC4B96CF85A85CEEDB8A'
magnet_redirect_server = 33747
session    = <aiohttp.client.ClientSession object at 0x129dbf9a0>
test_url   = 'http://localhost:33747'

src/tribler/core/utilities/tests/test_utilities.py:100: 
@drew2a drew2a self-assigned this Dec 11, 2023
@drew2a drew2a added this to the 7.14.0 milestone Dec 11, 2023
@drew2a
Copy link
Collaborator Author

drew2a commented Dec 11, 2023

It looks like we see the consequence of this error:

It has been fixed for Tribler in #7572 but for tests, it remains unfixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant