Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace __init__.py #47

Closed
BenTaylor-TfN opened this issue Aug 14, 2023 · 1 comment · Fixed by #27
Closed

Remove namespace __init__.py #47

BenTaylor-TfN opened this issue Aug 14, 2023 · 1 comment · Fixed by #27
Assignees
Labels
CI/CD Issues with GitHub Actions or other CI processes Revisit Revisit in future

Comments

@BenTaylor-TfN
Copy link
Member

BenTaylor-TfN commented Aug 14, 2023

PEP-420 updates namespace packages to be implicit.
Most work to achieve this was completed in #46.

Coverage was failing due to an empty __init__.py missing from the namespace package. This is a known issue: pytest-dev/pytest-cov#499

The above issue suggests this to solve. However adding the following into pyproject.toml, and removing the __init__.py:

[tool.coverage.report]
include_namespace_packages = true

Results in:

C:\ProgramData\Anaconda3\envs\caf.toolkit\lib\site-packages\coverage\inorout.py:523: CoverageWarning: Module caf.toolkit was previously imported, but not measured (module-not-measured)

And numerous files are missed in the coverage report, implying this argument is having no impact.

Revisit in future.

@BenTaylor-TfN BenTaylor-TfN self-assigned this Aug 14, 2023
@BenTaylor-TfN BenTaylor-TfN added the CI/CD Issues with GitHub Actions or other CI processes label Aug 14, 2023
@BenTaylor-TfN BenTaylor-TfN added the Revisit Revisit in future label Aug 14, 2023
@BenTaylor-TfN
Copy link
Member Author

Fixed in #27

@BenTaylor-TfN BenTaylor-TfN linked a pull request Sep 19, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Issues with GitHub Actions or other CI processes Revisit Revisit in future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant