Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag v3.6.0 version numer is 3.5.0 #151

Open
oPiZiL opened this issue Feb 18, 2021 · 2 comments
Open

Tag v3.6.0 version numer is 3.5.0 #151

oPiZiL opened this issue Feb 18, 2021 · 2 comments

Comments

@oPiZiL
Copy link

oPiZiL commented Feb 18, 2021

#define TOML11_VERSION_MAJOR 3
#define TOML11_VERSION_MINOR 5
#define TOML11_VERSION_PATCH 0
@ToruNiina
Copy link
Owner

Yes, that is a mistake, and is already fixed at the current commit. Changing the tag and github release files changes commit hash and affects on many things, so I cannot fix it. I will make a checklist to avoid the same mistakes.
If you have a nice idea, please share with me.

@oPiZiL
Copy link
Author

oPiZiL commented Feb 20, 2021

Sorry for my poor English firstly.
Maybe you can write a script to generate RELEASE asserts automaticlly
VERSION define can be a templated file lke toml.hpp.in, version number can be extracted from some CHANGELOG.md
so before you can release, you MUST prepare an updated CHANGELOG.md file, then execute the build script(can be write with shell, which turn toml.hpp.in into toml.hpp)
Above can ensure you modify VERSION number only in CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants