Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse response errors #81

Open
hypesystem opened this issue Jan 16, 2015 · 0 comments
Open

Parse response errors #81

hypesystem opened this issue Jan 16, 2015 · 0 comments
Labels
breaking change enhancement
Milestone
v1

Comments

@hypesystem
Copy link
Collaborator

https://developer.android.com/google/gcm/http.html#response

results in the response may contain an error. This should be parsed and should be returned as an error for the call (the call fails!), not as data.

This would break the interface and should be made as part of a major version bump.
@hypesystem hypesystem added this to the v1 milestone Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
v1
Development

No branches or pull requests
2 participants
@hypesystem @eladnava