Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent-base] allow for https session reuse #304

Open
lukekarrys opened this issue Mar 30, 2024 · 0 comments
Open

[agent-base] allow for https session reuse #304

lukekarrys opened this issue Mar 30, 2024 · 0 comments

Comments

@lukekarrys
Copy link
Collaborator

lukekarrys commented Mar 30, 2024

agent-base exports an agent that extends http.Agent. The secureEndpoint property works to make instances almost functionally equivalent to what you would get from https.Agent (defaultPort, protocol, getName, etc).

But the core https.Agent also includes SSL session reuse which would be nice to have.

Two options I can see here:

  • export another class that extends https.Agent. Users can choose to use this but it kinda defeats the purpose of the rest of the work agent-base does of having a single agent.
  • Use the secureEndpoint property to conditionally call https.Agent.prototype methods like getName does. Probably more work to implement and test but better UX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant