New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy issue with system proxy and Https Proxy agent #298
Comments
samuel-deal-tisseo
added a commit
to samuel-deal-tisseo/bruno
that referenced
this issue
Mar 21, 2024
This patched have been tested with http proxy: * on http requests * on https requests * on proxy auth with basic auth * on proxy without auth * on tinnyproxy proxy * on squid proxy It should have no effects on SOCK proxy (And I don't know if the issue exists on those config anyway) Given the following configuration * System proxy: http://system.proxy:8080 * Bruno proxy: http://explicit.proxy:9000 On http request (to http://neverssl.com): it try to send the http request to http://neverssl.com:8080 (wrong port) via the proxy http://explicit.proxy:9000 (correct proxy) On https request (to https://www.example.com): it try send a CONNECT ::1 request (can be seen with wireshark) An issue is opened on the proxy-agent repo: TooTallNate/proxy-agents#298 even tho I don't know if it's an axios issue, a proxy-agent issue or a bruno issue ```javascript import { parse as parseURL } from "url"; import axios from 'axios'; import { HttpsProxyAgent } from 'https-proxy-agent'; import { HttpProxyAgent } from 'http-proxy-agent'; class PatchedHttpsProxyAgent extends HttpsProxyAgent { async connect(req, opts) { const url = parseURL(req.path); url.port = Number(url.port) || (url.protocol.includes('https') ? 443 : 80); return super.connect(req, { ...opts, ...url }); } } function proxyObjToStr(proxyConf) { return proxyConf.protocol+"://"+proxyConf.host+":"+proxyConf.port.toString(); } function test_req(url, proxyConf, applyPatch) { let request = { method: 'get', url: url, responseType: 'string', httpAgent: new HttpProxyAgent(proxyObjToStr(proxyConf)), httpsAgent: new HttpsProxyAgent(proxyObjToStr(proxyConf)), proxy: proxyConf }; if (applyPatch) { request.proxy = {} request.httpsAgent = new PatchedHttpsProxyAgent(proxyObjToStr(proxyConf)); } const axiosInstance = axios.create(); const test_descr= url + (applyPatch ? " [patched]: " : " [current]: "); return axiosInstance(request).then(function (response) { console.log(test_descr + 'Ok'); }).catch(function (error) { console.log(test_descr + "KO"); if (error.response) { console.log({ http_head: error.response.request._header.split("\r\n")[0], path: error.response.request.path, host: error.response.request.host }); } }); } async function main() { process.env["HTTPS_PROXY"] = "http://implicit.proxy:8080"; const proxyConf = { protocol: 'http', host: 'explicit', port: 9000 }; await test_req("http://neverssl.com", proxyConf, false); await test_req("https://www.example.com/", proxyConf, false); await test_req("http://neverssl.com", proxyConf, true); await test_req("https://www.example.com/", proxyConf, true); } await main(); ``` Here the following result: ``` http://neverssl.com: KO { http_head: 'GET http://neverssl.com:8080/ HTTP/1.1', path: 'http://neverssl.com:8080/', host: 'implicit.proxy' } https://www.example.com/: KO { http_head: 'GET https://www.example.com:8080/ HTTP/1.1', path: 'https://www.example.com:8080/', host: 'implicit.proxy' } http://neverssl.com [patched]: Ok https://www.example.com/ [patched]: Ok ```
This was referenced Mar 21, 2024
I'm afraid I don't really understand what you're describing. Do you think you could submit a failing test case as a pull request? Also, try to take |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a system defined proxy and an explicit proxy config, requests failed using axios.
I'm not sure if it's an Axios or a httpsAgent issue (or that I don't use those two library correctly).
Example:
Given the following configuration
I have the following results:
The text was updated successfully, but these errors were encountered: