Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Updates agent-base to v6 #55

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

davidpatrick
Copy link
Contributor

There are many issues caused with using agent-base@4. This PR updates agent-base to v6 and dependencies that relied on agent-base@4.

  • small changes to adapt to changes on agent-base and proxy-agents
  • updated proxy dependencies that use agent-base@6
  • Tests run successfully on Node 6, 8, 10, 12, 14

Fixes #54
Fixes #44
Fixes #51
Fixes #27

- small changes to adapt to new api
- updated proxy dependencies that use agent-base@6
@apexad
Copy link

apexad commented Oct 7, 2020

Ping @TooTallNate please merge this as soon as possible and release a new version.

@TooTallNate TooTallNate merged commit d18c6bd into TooTallNate:master Oct 7, 2020
@TooTallNate
Copy link
Owner

Thanks for this! I was in the process of refactoring this one to TypeScript but put that down at some point. This is a good quick-fix.

@TooTallNate
Copy link
Owner

Published as v4.0.0

@apexad
Copy link

apexad commented Oct 7, 2020

@TooTallNate Be sure to update https://www.npmjs.com/package/superagent-proxy to use v4.0.0 now. (Preferable to bump super-agent-porxy to be 2.1.0 or 2.0.1 so that semver of stuff up the chain brings in the new version)

@davidpatrick
Copy link
Contributor Author

Thanks for publishing this @TooTallNate, the last thing we need to close the loop on is getting superagent-proxy to use this latest version. Looks like @apexad has already raised a PR for it TooTallNate/superagent-proxy#37

@TooTallNate
Copy link
Owner

@davidpatrick Done.

@davidpatrick
Copy link
Contributor Author

Thanks for the quick actions here @TooTallNate 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants