Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODOs #13

Open
1 of 3 tasks
szepeviktor opened this issue Mar 5, 2023 · 0 comments
Open
1 of 3 tasks

TODOs #13

szepeviktor opened this issue Mar 5, 2023 · 0 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Mar 5, 2023 •
edited

  • FileNameAndLineNumberAddingPreCompiler::setFileName Remove fluent interface from FileNameAndLineNumberAddingPreCompiler::setFileName #14
    remove fluent, make service method with fileName as argument to avoid miss-use
  • LaravelViewFunctionMatcher::match
    $funcName !== 'view' maybe make sure this function is coming from Laravel (Reflection)
  • ViewFunctionArgumentsNodeVisitor::enterNode
    2× ! $rootViewNode->name instanceof Identifier add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szepeviktor