Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative patterns to be used in an array #37

Merged
merged 2 commits into from Nov 8, 2021

Conversation

athieriot
Copy link

After using pr-labeler-action for a while, I wanted to be able to leverage the negative matcher as shown in the matcher documentation: https://www.npmjs.com/package/matcher#usage

Specifically what is shown in the first example:

matcher(['foo', 'bar', 'moo'], ['*oo', '!foo']);
//=> ['moo']

This PR propose that, when using a negative matcher in a list of patterns, the following example is viable and will only add one label for update/sbt-native-packager

patch: ['update/*', '!update/sbt-*']
no-release: update/sbt-*

The original behaviour is unchanged

@sjhewitt
Copy link

sjhewitt commented Nov 2, 2021

@TimonVS is there any chance you can review/merge/release this? It would be very useful functionality to have!

@TimonVS TimonVS merged commit 449c7ed into TimonVS:main Nov 8, 2021
@TimonVS
Copy link
Owner

TimonVS commented Nov 8, 2021

Thanks for your contribution @athieriot! I will release this soon.

@athieriot
Copy link
Author

Excellent ! Thank you so much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants