Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance configuration (#12, #15) #20

Merged
merged 11 commits into from Oct 27, 2019
Merged

enhance configuration (#12, #15) #20

merged 11 commits into from Oct 27, 2019

Conversation

amacado
Copy link
Contributor

@amacado amacado commented Oct 7, 2019

I decided to separate #11 "Configure using the with parameter" from this pull request since it is more complex and requires some more changes. Will see when I got some time to work on #11

@amacado amacado changed the title enhance configuration (#11, #12, #15) enhance configuration (#12, #15) Oct 7, 2019
@amacado amacado marked this pull request as ready for review October 7, 2019 22:15
Copy link
Owner

@TimonVS TimonVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! I left some feedback about the way the configuration path is provided :)

README.md Outdated Show resolved Hide resolved
src/action.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/action.js Outdated Show resolved Hide resolved
@amacado
Copy link
Contributor Author

amacado commented Oct 8, 2019

I will take a deeper look on your improvements and ideas @TimonVS, i'm quite busy at the moment so it can take a few days.

@TimonVS
Copy link
Owner

TimonVS commented Oct 8, 2019

@amacado sure! Take your time :)

@TimonVS
Copy link
Owner

TimonVS commented Oct 20, 2019

Hey @amacado, I was wondering if you still wanted to apply the changes. If not, please let me know so that I can apply them myself so that we can get this PR merged :)

@amacado
Copy link
Contributor Author

amacado commented Oct 21, 2019

Hey @TimonVS i was suffering a heavy cold the last two weeks and since it's my first day back in job I have a ton of work todo. If u have the time feel free to apply the changes, I would need at least a couple more weeks.

@TimonVS
Copy link
Owner

TimonVS commented Oct 22, 2019

Ah that's too bad about the cold :/, I hope you feel better soon!
I will probably apply the fixes myself sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants