Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't apply default config when custom config is provided #12

Closed
TimonVS opened this issue Sep 25, 2019 · 4 comments
Closed

Don't apply default config when custom config is provided #12

TimonVS opened this issue Sep 25, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@TimonVS
Copy link
Owner

TimonVS commented Sep 25, 2019

Currently we apply the default config even when a custom config is provided (https://github.com/TimonVS/pr-labeler-action/blob/master/index.js#L6), we should probably only apply the defaults when no config is present.

Related to #11
@amacado
Copy link
Contributor

amacado commented Sep 25, 2019

good point, we should work on this.

@amacado amacado mentioned this issue Oct 7, 2019
Closed
1 task
@amacado
Copy link
Contributor

amacado commented Oct 7, 2019

i'm working on this feature as well as on #11 and #15

@amacado amacado mentioned this issue Oct 7, 2019
Merged
2 tasks
@TimonVS
Copy link
Owner Author

TimonVS commented Oct 8, 2019

Nice! Thanks @amacado!

@TimonVS TimonVS added the bug Something isn't working label Oct 27, 2019
TimonVS added a commit that referenced this issue Oct 27, 2019
@TimonVS
Merge pull request #20 from amacado/feature/12-enhance-configuration
8803b71 
enhance configuration (#12, #15)
@TimonVS
Copy link
Owner Author

TimonVS commented Oct 27, 2019

Fixed in #20 and has been released in v3.1.0.

@TimonVS TimonVS closed this as completed Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimonVS @amacado