Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to Socket's ActiveConnections? #271

Open
CDVoidwalker opened this issue Mar 29, 2020 · 2 comments
Open

Access to Socket's ActiveConnections? #271

CDVoidwalker opened this issue Mar 29, 2020 · 2 comments

Comments

@CDVoidwalker
Copy link

Access to this as some public function would be very beneficial as it'd allow for broadcasting messages without building your stuff on top of it, cheers.

@ncallaway
Copy link
Contributor

@CDVoidwalker I was looking at this also, and will probably look at implementing this in the near future. I was talking to @TimonPost and we agreed that we didn't want to expose any of the internals of laminar.

Would something like Socket::get_connection(&self) -> -> impl Iterator<Item=SocketAddr> be sufficient for your purposes?

@TimonPost could you make me the assignee for this issue?

@CDVoidwalker
Copy link
Author

It's been a while since I've looked at the library, but the change you proposed sounds like it'd be sufficient. Some simple broadcasting function just using this get connection and iterating would also be great as I believe that most people do use it this way anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants