Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we resend messages with reliable guarantee on IO error? #264

Open
mvlabat opened this issue Oct 18, 2019 · 0 comments
Open

Should we resend messages with reliable guarantee on IO error? #264

mvlabat opened this issue Oct 18, 2019 · 0 comments

Comments

@mvlabat
Copy link

mvlabat commented Oct 18, 2019

As far as I understand if a user tries to send a message and it fails to any reason, Laminar will try to resend it after getting 32 packets without acknowledging the failed message.

We discussed the following case with @jstnlef on Discord:

Let's say if a user tries connecting with sending a reliable Handshake message and keeps doing it for several times (if they can't because of AddrNotAvailable error, for instance), then on success a server will get lots of handshakes from the same peer

I believe that in this case we should give a user possibility to decide what to do with such messages on error handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant