You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have an issue where, when a user isn't familiar with how our acking model works, the protocol gets further an further behind trying to send packets it's believed have been 'dropped'. It's so good at this job that, when a client isn't sending responses fast enough, the number of packets a server is sending balloons to ridiculous numbers.
Task TODO
Essentially, if we get some number of consecutive sends where the "dropped queue" is increasing, we should send a final error message, consider the client disconnected, and drop it.
Make something to count 'send' actions when dropped queue increases in size.
When the above triggers, consider the client to be disconnected, return Disconnect event.
The text was updated successfully, but these errors were encountered:
@jstnlef, what is to you the maximum number of times we should detect the growth of the queue before to take actions.
TimonPost
changed the title
Need to implement an "emergency shut off valve"
Implement shut off valve when dropped packets increases to fast
Jul 6, 2019
TimonPost
changed the title
Implement shut off valve when dropped packets increases to fast
Implement shut off valve when dropped packets vector grows to fast
Jul 6, 2019
Unsure about this. Can play around with a couple of settings but likely anywhere from 3 to 5 sends where the dropped packets vector is consistently increasing.
The dropped packets vector is only pushed to if we haven't received an ack for it in 33 packets. Therefore, in the places where this vector is continually increasing, it's safe to say we're in a pathologically bad state.
Task Description
We currently have an issue where, when a user isn't familiar with how our acking model works, the protocol gets further an further behind trying to send packets it's believed have been 'dropped'. It's so good at this job that, when a client isn't sending responses fast enough, the number of packets a server is sending balloons to ridiculous numbers.
Task TODO
Essentially, if we get some number of consecutive sends where the "dropped queue" is increasing, we should send a final error message, consider the client disconnected, and drop it.
Disconnect
event.The text was updated successfully, but these errors were encountered: