New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation Processor Option for Android's ArrayMap #78
Conversation
@sockeqwe What is your thought of this? |
Sorry, I completely forgot about this PR. Im very sorry! How would you use this option at the end? kapt {
arguments {
arg ("tikxml.arrayMap", "true")
}
} I think we could make this even more generic by passing the full qualified class name of kapt {
arguments {
arg ("tikxml.mapImpl", "android.support.v4.util.ArrayMap")
}
} Then we are pretty flexible with any kind of
or
The downside, however, is that |
|
Yes, but |
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=========================================
Coverage ? 65.45%
Complexity ? 812
=========================================
Files ? 126
Lines ? 3552
Branches ? 841
=========================================
Hits ? 2325
Misses ? 752
Partials ? 475
Continue to review full report at Codecov.
|
@sockeqwe "this implementation is a version of the platform's android.util.ArrayMap that can be used on older versions of the platform." https://developer.android.com/reference/androidx/collection/ArrayMap this one said "it is implements Map" |
Not sure if we need this. looks like a big |
@sockeqwe close this? |
No I will review it on Monday and most likely merge it. Sorry for the long pause and thanks again for your hard work. |
Fixed #37