Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive doctype #110

Merged
merged 2 commits into from Oct 12, 2018
Merged

Conversation

leondzn
Copy link
Contributor

@leondzn leondzn commented Oct 12, 2018

Some sources return doctype definitions in lowercase triggering the "Unterminated comment" error like on issue #80. I've made the check case insensitive.

@codecov-io
Copy link

Codecov Report

Merging #110 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #110      +/-   ##
============================================
+ Coverage     63.64%   63.64%   +<.01%     
- Complexity     1162     1164       +2     
============================================
  Files           237      237              
  Lines          4252     4253       +1     
  Branches       1021     1022       +1     
============================================
+ Hits           2706     2707       +1     
  Misses          897      897              
  Partials        649      649
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/com/tickaroo/tikxml/XmlReader.java 72.79% <100%> (+0.07%) 119 <3> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f2cb4...169b146. Read the comment docs.

@sockeqwe sockeqwe merged commit 0b19693 into Tickaroo:master Oct 12, 2018
@sockeqwe
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants