Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coveralls-python maintenance status #393

Closed
sodul opened this issue Feb 13, 2024 · 4 comments
Closed

coveralls-python maintenance status #393

sodul opened this issue Feb 13, 2024 · 4 comments

Comments

@sodul
Copy link

sodul commented Feb 13, 2024

There seems to be little activity on the project in recent years with issues that are not being directly addressed such as #373. If the project is no longer being actively maintained should it be updated to reflect that?

slimreaper35 added a commit to slimreaper35/cachi2 that referenced this issue Mar 15, 2024
Note: coveralls is an abandonware now, hasn't been touched
for a couple of years:
TheKevJames/coveralls-python#393

There is a problem when running GH workflows with coveralls==3.2.0
with having pyproject.toml as main configuration file for coverage:
`ImportError: cannot import name 'FnmatchMatcher' from 'coverage.files'`

Thats's why I fixed GH workflow to use latest coveralls==3.3.1

Signed-off-by: Michal Šoltis <msoltis@redhat.com>
slimreaper35 added a commit to slimreaper35/cachi2 that referenced this issue Mar 20, 2024
Note: coveralls is an abandonware now, hasn't been touched
for a couple of years:
TheKevJames/coveralls-python#393

There is a problem when running GH workflows with coveralls==3.2.0
with having pyproject.toml as main configuration file for coverage:
`ImportError: cannot import name 'FnmatchMatcher' from 'coverage.files'`

Thats's why I fixed GH workflow to use latest coveralls==3.3.1

Signed-off-by: Michal Šoltis <msoltis@redhat.com>
github-merge-queue bot pushed a commit to containerbuildsystem/cachi2 that referenced this issue Mar 20, 2024
Note: coveralls is an abandonware now, hasn't been touched
for a couple of years:
TheKevJames/coveralls-python#393

There is a problem when running GH workflows with coveralls==3.2.0
with having pyproject.toml as main configuration file for coverage:
`ImportError: cannot import name 'FnmatchMatcher' from 'coverage.files'`

Thats's why I fixed GH workflow to use latest coveralls==3.3.1

Signed-off-by: Michal Šoltis <msoltis@redhat.com>
@TheKevJames
Copy link
Owner

Hey all, maintainer here. This project ended up going unmaintained for a few years, mostly because between try to balance the competing priorities of supporting the latest coverage versions, python versions, etc as well as requests like #242 to maintain support for old versions of everything indefinitely, I found myself too fatigued to do anything.

In an effort to avoid getting hit by that issue again, I am coming down hard in favour of not supporting any end-of-life'd pythons, not supporting >5 year old (exact cutoff tbd) coverage versions, etc. Over the coming weeks, I'll aim to get everything cleaned up accordingly.

@sodul
Copy link
Author

sodul commented Apr 26, 2024

I'm very much in favor of only supporting versions of python that are still actively supported upstream. Folks that are sticking to older versions of python are taking security risks due to the lack of security fixes and should upgrade when possible.

Python 3.8 has much improved type annotation support which, combined with mypy, significantly improves bug detection.

I recommend that you look at pyupgrade as it is a great tool to help update existing code to newer python syntax with little work. We use pyugrade through gray, to auto format our codebase.

@TheKevJames
Copy link
Owner

@sodul thanks for the recommendation! I am indeed a fan of pyupgrade and have bumped it up to --py38-plus just today. You may also be interested in other linters in that file, lots of "autofix things for more modern python" stuff. Planning on making type hints required at some point, as well -- for now, I've used them wherever I touched code today, so it's probably close to the point where it's worth toggling 'em on in linting.

@tomato42
Copy link

Folks that are sticking to older versions of python are taking security risks due to the lack of security fixes and should upgrade when possible.

with all due respect, this is FUD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants