Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for parallel execution on CircleCI #336

Merged
merged 2 commits into from Nov 11, 2021

Conversation

Frank-Colson
Copy link
Contributor

Support for parallel execution with CircleCI does not function as expected. With 16 parallel execution nodes followed by the parallel-complete webhook, the following result is seen on the Coveralls dashboard. Note the .16 at the end, indicating that only the final node's coverage report was processed correctly.
Screen Shot 2021-11-10 at 9 52 46 AM

This PR makes a minor change to utilize the CIRCLE_NODE_INDEX, which is required for parallel execution support. This change mirrors the functionality from coveralls-ruby.

Utilizing e26d574, subsequent runs yielded the expected results on the Coveralls dashboard.
Screen Shot 2021-11-10 at 9 53 06 AM

Copy link
Owner

@TheKevJames TheKevJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! LGTM

@TheKevJames TheKevJames merged commit 2610885 into TheKevJames:master Nov 11, 2021
andy-maier pushed a commit to andy-maier/coveralls-python that referenced this pull request Dec 23, 2022
Co-authored-by: Elijah Shaw-Rutschman <elijahr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants