Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/configuration: Avoid over-exposing GITHUB_TOKEN #332

Merged
merged 1 commit into from Nov 3, 2021

Conversation

jku
Copy link
Contributor

@jku jku commented Nov 2, 2021

The GITHUB_TOKEN in this example should of course be just a read-only token but in any case secrets should not be exposed to code that does not need them. In this case pip does not need to authenticate to GitHub.

The GITHUB_TOKEN in this example _should_ be just read-only token but in any case secrets should not be exposed to code that does not need them. In this case pip does not need to authenticate to GitHub.
@jku jku requested a review from TheKevJames as a code owner November 2, 2021 09:42
Copy link
Owner

@TheKevJames TheKevJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, thanks for the contribution!

@TheKevJames TheKevJames merged commit f5ebce6 into TheKevJames:master Nov 3, 2021
andy-maier pushed a commit to andy-maier/coveralls-python that referenced this pull request Dec 23, 2022
The GITHUB_TOKEN in this example _should_ be just read-only token but in any case secrets should not be exposed to code that does not need them. In this case pip does not need to authenticate to GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants