fix(env): fixup handling of default env service values #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the mapping between default (eg. `COVERALLS_*`) env vars and the equivalent config values, which had some mismatches for job identification cases. Fixes #303
TheKevJames
force-pushed
the
kj/fixup-service-id-from-env
branch
from
deb47af
to
df550ce
Compare
ashleysommer
approved these changes
Oct 25, 2021
|
@TheKevJames sorry I missed this review request. This does fix my issue, thanks! |
|
@ashleysommer no problem -- and thanks for confirming! |
andy-maier
pushed a commit
to andy-maier/coveralls-python
that referenced
this pull request
Dec 23, 2022
Fixes the mapping between default (eg. `COVERALLS_*`) env vars and the equivalent config values, which had some mismatches for job identification cases. Fixes TheKevJames#303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mapping between default (eg.
COVERALLS_*) env vars and theequivalent config values, which had some mismatches for job
identification cases.
Fixes #303