New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with COVERALLS_FLAG_NAME statement in "Github Actions Gotcha" doc section #243
Comments
Addressed by PR #244. |
Update: I played around with re-running jobs (via GitHub Actions re-run) and the effect is that coveralls.io still combines the jobs properly into a consolidated result for the same build, but in its list of it jobs within the build it shows e.g. 13 instead of the expected 10 jobs. I assume that is what the original text described in its statement about "piling up builds". However, it turns out that ths "piling up" happens in all of the three cases described above. You can see that in the linked examples, each of them should show 10 jobs in the build, but they show more. So while there is a "piling up bug" somewhere, it is not circumvented by specifying a unique value for COVERALLS_FLAG_NAME, as the original text had suggested. Also, very strange: The number of jobs shown for a build varies within certain limits when refreshing the browser window. That happens for all three cases. Bottom line: When reviewing the PR, one consideration might be to describe the "piling up" effect, but at this point I'm not sure we have a way to avoid it, so the question is, is it worth while to say something about it. After all, the combined coverage result seems to be ok in all three cases, as far as I can tell. |
Thanks again for the PR! |
The documentation states in section Github Actions Gotcha:
I think that COVERALLS_FLAG_NAME is not required (maybe it was in the past?), and that if provided it does not need to be unique. I have successfully used version 2.1.2 of
coveralls
in parallel mode on GitHub Actions without specifyingCOVERALLS_FLAG_NAME
. The resulting jobs combine successfully on coveralls.io. The identification string contains GITHUB_RUN_ID and a sequence number in any case, and COVERALLS_FLAG_NAME only adds to it:I suggest to clarify that in the docs.
The text was updated successfully, but these errors were encountered: