0.5.18?: Add spellcheck

[TheGoddessInari]

Assuming people want this, we can reasonably do so, at least for English, French, German, and Spanish.

[TheGoddessInari]

Like mobile WebView, it appeared this was easily possible, but in testing nothing happened, despite wiring up a spellchecker according to documentation. This means either:

1. Electron's documentation is wrong and there's just some other way to wire it up. I wired it up according to docs, similar to how other projects do it, and nothing happened.
2. Electron 2.0.x is interfering with it, similar to how it messes with some other things.
3. ExtJS is somehow interfering.

The second is probably the most likely, so I'll do another test build with it and electron 1.8.7. In some cases, things may need to update to electron 2.0.x, let alone 3.0 coming very soon.

[TheGoddessInari]

Trying an alternate approach today that might work better for spellcheck and context menu. Initial results are promising.

[HaleTom]

Thanks for your work on this. Your commitment to this project is outstanding. I hope you continue to receive support.

[BuildTheRobots]

Apologies for bumping without contributing anything of value, but I don't suppose there's been an update on the spellcheck feature?

[prediscover]

Eager for spellcheck! Noticed some changes in the new release, was there an update?

[parf78]

Curious if there's been any update on this? Spellcheck is the only thing holding me back.

[BuildTheRobots]

Is it possible to have an update please, as this is a feature that a number of people are desperate for.
I notice that we've updated Electron by both major and minor versions since the last attempt - I assume that would make a difference?
Greatest of thanks.

[eliliam]

I just found this project after looking for some way to get spell check into Rambox, I am considering switching and spell check would be a major part of that for me. I see the ticket is still in the To Do section, has there been any developments with this yet?

[TheGoddessInari]

Electron added built-in spellcheck. Expect this soon if it's sane.

[TheGoddessInari]

This appears broken upstream even on 8.0.0 for Windows/Linux. Only works on MacOS.

Eg https://user-images.githubusercontent.com/42934634/72342048-6d1ff900-36d4-11ea-9f9b-0650553a6cb7.png

[eliliam]

That's great news, is there a quick patch that I can make to enable spell check before it officially is implemented?

[TheGoddessInari]

Fixed with electron 8.10 and 1588c5e. Unsurprisingly it was an upstream issue on 8.0.0 that kept it from working on Windows.

[SebGay]

Hi there,
Thanks very much for this last update, spellcheck is a killer feature.

I'm having trouble getting it to work across all my services though- currently I have it working on Messenger and Gmail (although I suspect the latter is the inbuilt gmail one) but not on Whatsapp (web)/LinkedIn messaging.

Is this to do with how these particular web platforms are constructed and electron not recognising userfields to spellcheck?

It appears that by restarting with hardware acceleration on (unticking disable in preferences), then disabling again (ticking) the spellcheck now works on all platforms. Even with hardware acceleration. I have no idea why this toggle did anything.

One thing that might make your life easier A possible future feature is the Languagetool chromium plugin. I don't know anything about javascript/electron but based on this bug report (which I found from a SO thread) it appears chromium extensions could soon be ready to hitch onto electron.

If that's the case, perhaps you could enable a setting to turn install/turn on languagetools and that way the spellcheck will work across all platforms and also include grammer checking (plus a huge language library).

[BKPepe]

Am I doing something wrong or spellcheck in Hamsket supports just English?

[TheGoddessInari]

I'll figure out a way to get Electron loading the right dictionaries based on language selected, it just might end up a pain since everything expects different language abbreviations.

…

On Wed, Mar 18, 2020, 4:49 AM Josef Schlehofer ***@***.***> wrote: Am I doing something wrong or spellcheck in Hamsket supports just English? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJHR27BU4TAS4TVCXUZ4NBLRICYLXANCNFSM4FOC25LQ> .

[leogallego]

I'll figure out a way to get Electron loading the right dictionaries based on language selected, it just might end up a pain since everything expects different language abbreviations.

Is there a way to enable the spell check language per tab maybe?

Usually most of us who are not native English speakers use one language for the interface but have several services in different languages, even if we had the interface in the right language, there would be services were the spell checker wouldn't work.

ps. maybe this should be reopened or made another issue as a feature request?