-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm & bundle js for browser #1
Comments
I've given up on this issue. JS tooling simply doesn't make this easy. It's like writing code in the 90s, no compass, no map. If someone wants to attempt it we need the following libraries bundled:
We'll also need the emoji library bundled. For scaffolding, we only need ipfs-http-client. If I attempt this again, it will be focused only on that. For DiscoChat itself, it's unlikely we'll ever use webpack (unless someone wants to put in the non-trivial effort into making that happen). This would be a great start, but unfortunately I'm either wrestling with the tools or I'm getting useless errors ( Alternatively building our own tooling seems fine, it would likely take less time... |
I ran into the exact same bug after removing every single module except Custom tool sounds like the easiest option, just crawl the dependencies, |
Custom tool minimal example: import json, shutil
package = json.load(open("package.json"))
for i in package["dependencies"]:
shutil.copyfile("node_modules/%s/dist/index.min.js" % i, "ui/%s.min.js" % i) |
Updating this issue to note: If a package manager other than npm is better, totally not "locked-in" to npm. |
Right now we just use vanilla JS, but in order to be more friendly to new developers an npm & webpack system would likely simplify things.
The text was updated successfully, but these errors were encountered: