From c7b0c4c1534a5e787e10afae16b97b5731118b91 Mon Sep 17 00:00:00 2001 From: Shubh Srivastava Date: Sun, 20 Nov 2022 22:44:38 +0530 Subject: [PATCH] Issue #12326: Resolve Pitest suppression for AccessModifierOption --- .../javadoc/JavadocMethodCheckTest.java | 9 ++++++ .../InputJavadocMethodAccessModifier.java | 30 +++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/javadocmethod/InputJavadocMethodAccessModifier.java diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java index 96416a09b73..ebfcea750db 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java @@ -209,6 +209,15 @@ public void testScopeInnerInterfacesPublic() throws Exception { getPath("InputJavadocMethodScopeInnerInterfaces.java"), expected); } + @Test + public void testTrimProperty() throws Exception { + final String[] expected = { + "27: " + getCheckMessage(MSG_RETURN_EXPECTED), + }; + verifyWithInlineConfigParser( + getPath("InputJavadocMethodAccessModifier.java"), expected); + } + @Test public void testScopeAnonInnerPrivate() throws Exception { final String[] expected = CommonUtil.EMPTY_STRING_ARRAY; diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/javadocmethod/InputJavadocMethodAccessModifier.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/javadocmethod/InputJavadocMethodAccessModifier.java new file mode 100644 index 00000000000..1e18132d1bd --- /dev/null +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/javadocmethod/InputJavadocMethodAccessModifier.java @@ -0,0 +1,30 @@ +/* +JavadocMethod +allowedAnnotations = (default)Override +validateThrows = (default)false +accessModifiers = \tpublic +allowMissingParamTags = (default)false +allowMissingReturnTag = (default)false +tokens = (default)METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF, COMPACT_CTOR_DEF + + +*/ + +package com.puppycrawl.tools.checkstyle.checks.javadoc.javadocmethod; + +public class InputJavadocMethodAccessModifier { + class classOne { + + } + + class classTwo { + + } + + /** + * @return + */ + public String method1() { // violation '@return tag should be present and have description' + return "arbitrary_string"; + } +} \ No newline at end of file