Footer in ModalScreen lists ignored App keybindings

[twrightsman]

When I add a Footer to a ModalScreen it lists the screen's keybindings as well as the App's keybindings, even though the App's keybindings are disabled. I would expect only the ModalScreen's keybindings to be displayed?

Here is a diff to modal02.py that shows this:

@@ -15,6 +15,8 @@
 class QuitScreen(ModalScreen):
     """Screen with a dialog to quit."""
 
+    BINDINGS = [("f", "request_foo", "Foo")]
+    
     def compose(self) -> ComposeResult:
         yield Grid(
             Label("Are you sure you want to quit?", id="question"),
@@ -22,6 +24,7 @@
             Button("Cancel", variant="primary", id="cancel"),
             id="dialog",
         )
+        yield Footer()
 
     def on_button_pressed(self, event: Button.Pressed) -> None:
         if event.button.id == "quit":
@@ -29,6 +32,9 @@
         else:
             self.app.pop_screen()
 
+    def action_request_foo(self) -> None:
+        print("I pity thee")
+
 
 class ModalApp(App):
     """An app with a modal dialog."""

[github-actions]

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

[twrightsman]

I made a patch that fixes the Footer (main...twrightsman:textual:main), but haven't yet run the test suite.

There is probably a better way to do this; maybe just iterating over _modal_binding_chain in namespace_bindings rather than just replicating _modal_binding_chain's behavior and checking is_modal.

[twrightsman]

Fixed in 0.61

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.