Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML format (reverse pre and code tags) #2642

Merged
merged 3 commits into from Dec 4, 2022

Conversation

pawamoy
Copy link
Contributor

@pawamoy pawamoy commented Nov 12, 2022

Type of changes

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review. 馃槀

Description

I've reversed the pre and code tags in the base HTML format. Otherwise it looks like the browser terminates the first code tag early, wraps it in a p, and then re-uses code in the pre tag 馃槙

PRE:

The PRE element tells visual user agents that the enclosed text is "preformatted". When handling preformatted text, visual user agents:

May leave white space intact.
May render text with a fixed-pitch font.
May disable automatic word wrap.
Must not disable bidirectional processing.

CODE:

Designates a fragment of computer code.

@pawamoy
Copy link
Contributor Author

pawamoy commented Nov 12, 2022

Let me know if you want me to update the changelog.

@pawamoy
Copy link
Contributor Author

pawamoy commented Nov 12, 2022

OK I'll clone that locally and fix the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] export_html leaks style into the page
2 participants