Make repr tag highlighting greedy #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.39% // Head: 98.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2565 +/- ##
==========================================
- Coverage 98.39% 98.39% -0.01%
==========================================
Files 63 63
Lines 6806 6797 -9
==========================================
- Hits 6697 6688 -9
Misses 109 109
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Does this deserve an entry in the |
|
Great. Please add a test for this. |
And also run freshly-installed pre-commit hooks (hence ISO8601Highlighter moving in the import list).
1 task
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2468; before this change the tag-matching code was non-greedy, resulting in an unbalanced match if there were tags within tags. This change makes this greedy to ensure that there's a better chance of the match being balanced.
Type of changes
Checklist
Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.