From 75d405c49560b7671b4b423c6d336d0dca46008a Mon Sep 17 00:00:00 2001 From: Darren Burns Date: Fri, 23 Sep 2022 12:19:08 +0100 Subject: [PATCH 1/2] Remove unused height parameter from Layout class --- rich/layout.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/rich/layout.py b/rich/layout.py index 2030c0401..50ebd1882 100644 --- a/rich/layout.py +++ b/rich/layout.py @@ -20,8 +20,8 @@ from .highlighter import ReprHighlighter from .panel import Panel from .pretty import Pretty -from .repr import rich_repr, Result from .region import Region +from .repr import Result, rich_repr from .segment import Segment from .style import StyleType @@ -162,7 +162,6 @@ def __init__( minimum_size: int = 1, ratio: int = 1, visible: bool = True, - height: Optional[int] = None, ) -> None: self._renderable = renderable or _Placeholder(self) self.size = size @@ -170,7 +169,6 @@ def __init__( self.ratio = ratio self.name = name self.visible = visible - self.height = height self.splitter: Splitter = self.splitters["column"]() self._children: List[Layout] = [] self._render_map: RenderMap = {} From 4a858cf7f6ae34f66b95b582c17333dfbdd8cddc Mon Sep 17 00:00:00 2001 From: Darren Burns Date: Fri, 23 Sep 2022 12:21:05 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6eebd4fd..50ae226a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix NO_COLOR support on legacy Windows https://github.com/Textualize/rich/pull/2458 - Fix pretty printer handling of cyclic references https://github.com/Textualize/rich/pull/2524 - Fix missing `mode` property on file wrapper breaking uploads via `requests` https://github.com/Textualize/rich/pull/2495 +- Remove unused height parameter in `Layout` class https://github.com/Textualize/rich/pull/2540 ### Changed