Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding support to Syntax #2247

Merged
merged 14 commits into from May 3, 2022
Merged

Add padding support to Syntax #2247

merged 14 commits into from May 3, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented May 3, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Add padding support to Syntax.

Closes #2240

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #2247 (b18d59f) into master (14d47c9) will decrease coverage by 0.08%.
The diff coverage is 96.46%.

@@            Coverage Diff             @@
##           master    #2247      +/-   ##
==========================================
- Coverage   98.88%   98.80%   -0.09%     
==========================================
  Files          73       73              
  Lines        7629     7668      +39     
==========================================
+ Hits         7544     7576      +32     
- Misses         85       92       +7     
Flag Coverage Δ
unittests 98.80% <96.46%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/_export_format.py 100.00% <ø> (ø)
rich/console.py 98.28% <95.87%> (-0.50%) ⬇️
rich/syntax.py 99.30% <100.00%> (+0.02%) ⬆️
rich/terminal_theme.py 100.00% <100.00%> (ø)
rich/traceback.py 98.68% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a999f4...b18d59f. Read the comment docs.

@darrenburns darrenburns marked this pull request as ready for review May 3, 2022 15:21
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Would you mind updating CHANGELOG before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add padding to Syntax
3 participants