Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPy3 test fixes #1904

Merged
merged 2 commits into from Feb 9, 2022
Merged

PyPy3 test fixes #1904

merged 2 commits into from Feb 9, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Feb 1, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

  1. Fix test_syntax to compare strings via == rather than is, in order to fix test failure on PyPy3.
  2. Skip a few test_inspect tests on PyPy3 that fail due to different output.

Fix test_syntax to compare strings via "==" rather than "is", in order
to fix test failure on PyPy3.
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #1904 (f15dc3e) into master (e839bfb) will decrease coverage by 0.02%.
The diff coverage is 98.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1904      +/-   ##
==========================================
- Coverage   99.82%   99.80%   -0.03%     
==========================================
  Files          71       71              
  Lines        6943     7032      +89     
==========================================
+ Hits         6931     7018      +87     
- Misses         12       14       +2     
Flag Coverage Δ
unittests 99.80% <98.99%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/default_styles.py 100.00% <ø> (ø)
rich/markdown.py 100.00% <ø> (ø)
rich/syntax.py 99.27% <97.72%> (-0.34%) ⬇️
rich/pretty.py 99.71% <98.88%> (-0.29%) ⬇️
rich/__main__.py 100.00% <100.00%> (ø)
rich/_inspect.py 100.00% <100.00%> (ø)
rich/color.py 100.00% <100.00%> (ø)
rich/console.py 100.00% <100.00%> (ø)
rich/segment.py 99.34% <100.00%> (+0.05%) ⬆️
rich/table.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94273ee...f15dc3e. Read the comment docs.

@mgorny mgorny changed the title Fix test_syntax not to use identity comparison on string PyPy3 test fixes Feb 1, 2022
Mark the test_inspect tests failing on PyPy3 due to different output
to be skipped appropriately.
@mgorny
Copy link
Contributor Author

mgorny commented Feb 9, 2022

Ping.

@willmcgugan
Copy link
Collaborator

Thanks.

@willmcgugan willmcgugan merged commit 5fafb92 into Textualize:master Feb 9, 2022
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 21, 2022
11.2.0

Added

Add support for US spelling of "gray" in ANSI color names Textualize/rich#1890
Added rich.diagnose.report to expose environment debugging logic as function Textualize/rich#1917
Added classmethod Progress.get_default_columns() to get the default list of progress bar columns Textualize/rich#1894

Fixed

Fixed performance issue in measuring text
Fixed test failures on PyPy3 Textualize/rich#1904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants