Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(syntax): include padding with background color override #3296

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(syntax): include padding with background color override #3296

wants to merge 3 commits into from

Conversation

TomJGooding
Copy link

@TomJGooding TomJGooding commented Feb 29, 2024 •
edited

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes #3295. I've tested manually but I'm afraid not sure how to add a proper test for this.

Before:

image

After:

image

@TomJGooding TomJGooding marked this pull request as ready for review February 29, 2024 21:16
@TomJGooding
Copy link
Author

TomJGooding commented Feb 29, 2024 •
edited

I've now added a test based on the others, where I assume you just copy paste the result from print(repr(result)) and then check that? (If Will has actually written these by hand I'm seriously impressed!)

If that's not the proper way to test this, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Overriding background_color of Syntax doesn't include padding
1 participant
@TomJGooding