Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.6 as a supported version of Python #2566

Closed
7 tasks done
davep opened this issue Oct 10, 2022 · 2 comments · Fixed by #2567
Closed
7 tasks done

Drop Python 3.6 as a supported version of Python #2566

davep opened this issue Oct 10, 2022 · 2 comments · Fixed by #2567
Assignees
@davep
Labels
Needs triage

Comments

@davep
Copy link
Contributor

davep commented Oct 10, 2022 •
edited

Time to drop Python 3.6 as a version of Python supported by Rich. The reasons for doing so include:

Actions to take include:

  • Consider the significance of this TODO in _null_file.py.
  • Drop dataclasses as a dependency.
  • Look at dropping the special-casing of isascii in rule.py.
  • Drop Python 3.6 from pythonpackage.yml.
  • Drop mention of Python 3.6 in pyproject.toml -> [tool.poetry] -> classifiers.
  • Bump the major version of Rich.
  • Update the Compatibility section of README.md (and all translations).
davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Drop Python 3.6 from testing in GitHub actions
05707d5 
See Textualize#2566.
davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Remove Python 3.6 from the classifiers in pyproject.toml
d5fe471 
See Textualize#2566.
davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Bump the minimum Python dependency to 3.7
db7fc1a 
See Textualize#2566.
davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Remove dataclasses as a dependency
df76397 
Python 3.7 is now our minimum-supported Python, and so we don't need to pull
in dataclasses any more.

See Textualize#2566.
davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Don't special-case an isascii implementation for Python 3.6
419265b 
Python 3.7 is now our minimum-supported Python, and so we don't need to add
our own version of isascii any more.

See Textualize#2566.
davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Drop extra IO type properties only needed by Python 3.6
873cb79 
Python 3.7 is now our minimum-supported Python, and so we don't need to add
these properties any more.

See Textualize#2566.
davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Update README.md to say Python 3.7 is the minimum Python
43a20cc 
See Textualize#2566.
davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Bump the major version of Rich
a490f09 
The minimum-supported Python has changed from 3.6.x to 3.7. See Textualize#2566.
@davep davep mentioned this issue Oct 10, 2022
Merged
@davep davep self-assigned this Oct 10, 2022
@davep
Copy link
Contributor Author

davep commented Oct 10, 2022

Currently blocked by testing-via-actions as there's an issue with Poetry and Windows testing.

davep added a commit to davep/rich that referenced this issue Oct 10, 2022
@davep
Drop types-dataclasses as a development dependency
cb2f77d 
Now that we've dropped dataclasses as a dependency, this can be dropped too.

See Textualize#2566.
@davep davep linked a pull request Oct 11, 2022 that will close this issue
Drop Python 3.6 as the minimum-supported Python version #2567
Merged
@github-actions
Copy link

Did I solve your problem?

Why not buy the devs a coffee to say thanks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davep davep

Labels
Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop Python 3.6 as the minimum-supported Python version davep/rich
1 participant
@davep