Skip to content

feat: add CreateSymbolicLink support #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2022
Merged

feat: add CreateSymbolicLink support #871

merged 4 commits into from
Aug 15, 2022

Conversation

davidrogers090
Copy link
Contributor

Adds a FileSystemInfo extension for wrapping convenience.
Adds FEATURE_CREATE_SYMBOLIC_LINK to the build properties.
Includes mock implementations and mock tests.
Updates the ApiParityTests to no longer ignore CreateSymbolicLink for .net 6.0.
Bumps the version in version.json.

See #869

Adds a FileSystemInfo extension for wrapping convenience.
Adds FEATURE_CREATE_SYMBOLIC_LINK to the build properties.
Includes mock implementations and mock tests.
Updates the ApiParityTests to no longer ignore CreateSymbolicLink for .net 6.0.
Bumps the version in version.json.
@davidrogers090 davidrogers090 changed the title Adds CreateSymbolicLink support feat:Adds CreateSymbolicLink support Aug 9, 2022
@davidrogers090 davidrogers090 changed the title feat:Adds CreateSymbolicLink support feat: Adds CreateSymbolicLink support Aug 9, 2022
@fgreinacher fgreinacher changed the title feat: Adds CreateSymbolicLink support feat: add CreateSymbolicLink support Aug 9, 2022
fgreinacher and others added 2 commits August 10, 2022 19:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, thanks @davidrogers090 👍

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mergify mergify bot merged commit defd44b into TestableIO:main Aug 15, 2022
@github-actions
Copy link

This is addressed in release v17.0.28.

@github-actions github-actions bot added the state: released Issues that are released label Aug 15, 2022
vbreuss pushed a commit to vbreuss/System.IO.Abstractions that referenced this pull request Aug 26, 2022
* Adds CreateSymbolicLink support

Adds a FileSystemInfo extension for wrapping convenience.
Adds FEATURE_CREATE_SYMBOLIC_LINK to the build properties.
Includes mock implementations and mock tests.
Updates the ApiParityTests to no longer ignore CreateSymbolicLink for .net 6.0.
Bumps the version in version.json.

* Skip path tests on non-Windows platform

Co-authored-by: Florian Greinacher <florian@greinacher.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: released Issues that are released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants