fix: consider readonly files when deleting directories #863
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to delete directory recursively
VictorLlanir
changed the title
fgreinacher
reviewed
Jul 11, 2022
There was a problem hiding this comment.
Thanks a lot @VictorLlanir, I have a small question/suggestion, let me know what you think.
|
You're right, @fgreinacher. I'm going to fix this and update this PR. |
fgreinacher
changed the title
fgreinacher
approved these changes
Jul 15, 2022
1 task
This was referenced Jul 16, 2022
|
This is addressed in release v17.0.23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #849 by implementing directory validation for ReadOnly files when trying to delete directory recursively
On the RemoveFile method, there was no validation to check if there is a ReadOnly file inside the directory berfore trying to remove. This PR implements this validation.