Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more attributes of EnumerationOptions #653

Open
P-Storm opened this issue Oct 9, 2020 · 3 comments
Open

Add more attributes of EnumerationOptions #653

P-Storm opened this issue Oct 9, 2020 · 3 comments
Labels
area: testinghelpers Issues that address the testing helpers state: ready to pick Issues that are ready for being worked on type: enhancement Issues that propose new functionality

Comments

@P-Storm
Copy link
Contributor

P-Storm commented Oct 9, 2020

Describe the bug
See #652 .

I see more problems in the future with the following settings in:

  • MatchType = MatchType.Win32,
  • IgnoreInaccessible
  • ReturnSpecialDirectories
  • AttributesToSkip
  • MatchCasing

To Reproduce
Use one of the top usings to see if that works.

Additional context
I know that EnumerationOptions is one of the newest addition of the code, but it is incomplete.
@P-Storm P-Storm added state: needs discussion Issues that need further discussion type: bug Issues that describe misbehaving functionality labels Oct 9, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type: enhancement to this issue, with a confidence of 0.67. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the type: enhancement Issues that propose new functionality label Oct 9, 2020
@fgreinacher fgreinacher added area: testinghelpers Issues that address the testing helpers and removed type: bug Issues that describe misbehaving functionality labels Oct 12, 2020
fgreinacher added a commit that referenced this issue Oct 12, 2020
@fgreinacher
refactor: throw exception when encountering unsupported EnumerationOp…
c3e036c 
…tions

Addresses #653
@fgreinacher fgreinacher mentioned this issue Oct 12, 2020
Merged
fgreinacher added a commit that referenced this issue Oct 12, 2020
@fgreinacher
refactor: throw exception when encountering unsupported EnumerationOp…
aa58a66 
…tionsAddresses #653
fgreinacher added a commit that referenced this issue Oct 12, 2020
@fgreinacher
refactor: throw exception when encountering unsupported EnumerationOp…
cdea682 
…tions (#655)

Addresses #653
@fgreinacher fgreinacher added state: ready to pick Issues that are ready for being worked on and removed state: needs discussion Issues that need further discussion labels Oct 13, 2020
@fgreinacher
Copy link
Contributor

With #655 we now explicitly throw NotSupportedExceptions when encountering unsupported EnumerationOptions property values.

@Chaosflo
Copy link

Chaosflo commented Nov 24, 2022 •
edited

Hey,
When I was testing a class, I came over this problem.
Its already 2 years after, oh man time flies

Whats the status of this?

I need the MatchCasing.CaseSensitive it seems

This was referenced May 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: testinghelpers Issues that address the testing helpers state: ready to pick Issues that are ready for being worked on type: enhancement Issues that propose new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fgreinacher @P-Storm @Chaosflo