Investigate why checkboxes don't work in some CI builds.

[na9da]

How to reproduce issue:

• Visit http://ci.terria.io/handle-external-link/
• Open "Map Settings" or the Feedback form
• Click the checkboxes
• See that the checboxes don't change

So far we have found that the generated code for HiddenCheckbox.tsx is different for the working and broken one.

Generated code for working build:

return /*#__PURE__*/_react["default"].createElement(_StyledInput, _extends({
    type: "checkbox"
  }, props, {
    ref: ref,
    "aria-checked": isIndeterminate ? "mixed" : props.checked
  }));

Generate code for broken build:

return /*#__PURE__*/_react["default"].createElement(_StyledInput, {
    type: "checkbox",
    ref: ref,
    "aria-checked": isIndeterminate ? "mixed" : props.checked
  });

See how in the broken build, props don't get passed to createElement. Because props get elided, the hidden input element will not trigger onChange callback passed via props.

We need to narrow down and figure out if this is caused by some updated package or something else.

[wibily]

timebox to 1 day to investigate.
Heissenbug that only affects Mike's machine and CI on handle-external-link

[na9da]

It now affects the build for main too - http://ci.terria.io/main/

[na9da]

Looks related to - styled-components/babel-plugin-styled-components#359 (comment)
and a fix is on the way - styled-components/babel-plugin-styled-components#361

[klarstrup]

just fyi this problem is not in babel-plugin-styled-components 2.0.0 - only 2.0.1