Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example支持cls产品 #112

Merged
merged 2 commits into from Jul 20, 2021
Merged

example支持cls产品 #112

merged 2 commits into from Jul 20, 2021

Conversation

lleiyyang
Copy link
Contributor

No description provided.

message LogTag
{
required string key = 1;
required string value = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些未对齐,看起来是空格和tab混排造成的,麻烦统一一下吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

optional string contextFlow= 2;
optional string filename = 3;
optional string source = 4;
repeated LogTag logTags = 5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同样的

@@ -0,0 +1,41 @@
# -*- coding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createlogset.py =》 create_logset.py 或者 create_log_set.py ,我不太确定logset是否是cls的术语

from tencentcloud.common import credential
from tencentcloud.common.exception.tencent_cloud_sdk_exception import TencentCloudSDKException
# 导入对应产品模块的client models。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不必要的空行

from tencentcloud.common.exception.tencent_cloud_sdk_exception import TencentCloudSDKException
# 导入对应产品模块的client models。

from tencentcloud.cls.v20201016 import cls_client, models
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

分两行导入,不要两个模块逗号隔开


client = cls_client.ClsClient(cred, "ap-guangzhou", clientProfile)
req = models.CreateTopicRequest()
req.LogsetId = "xxx"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@@ -0,0 +1,41 @@
# -*- coding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createtopic.py =》create_topic.py

# -*- coding:utf-8 -*-
import sys

import cls_kv_pb2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

工程内的模块置于标准库之后

import cls_kv_pb2
import time
import json
import sys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重复的导入

# 实例化一个client选项,可选的,没有特殊需求可以跳过。
clientProfile = ClientProfile()
clientProfile.signMethod = "TC3-HMAC-SHA256" # 指定签名算法(默认为HmacSHA256)
clientProfile.unsignedPayload = True
Copy link
Member

@zqfan zqfan Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这并非公开的字段,而且这种控制类的请求并不建议打开,
整个配置示例字段其实并无十分的必要。下同

@zqfan zqfan merged commit 7555d97 into TencentCloud:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants