凭证管理支持获取默认凭证 #106
Merged
凭证管理支持获取默认凭证 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zqfan
requested changes
Jun 29, 2021
tencentcloud/common/credential.py
Outdated
| :param secretKey: The secret key of your credential. get by environment variable TENCENTCLOUD_SECRET_KEY | ||
| :type secretKey: str | ||
| """ | ||
| self.secretId = os.environ.get('TENCENTCLOUD_SECRET_ID') |
There was a problem hiding this comment.
secretId => secret_id，其他的也都改一下吧
看下是否需要实时读取
tencentcloud/common/credential.py
Outdated
| client_config = ini_map.get("default") | ||
| self.secretId = client_config.get('secret_id', None) | ||
| self.secretKey = client_config.get('secret_key', None) | ||
| self.role_name = client_config.get('role_name', None) |
There was a problem hiding this comment.
role_name => role_arn，因为sts现在没有根据role_name查role_arn的公开接口
tencentcloud/common/credential.py
Outdated
| if self.cred is not None: | ||
| return self.cred | ||
|
|
||
| raise TencentCloudSDKException("no valid credentail.") |
There was a problem hiding this comment.
TencentCloudSDKException("ClientSideError", "no valid credentail.") ，要指明错误码，这种就判定为客户端错误就好了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.